Skip to content

Commit

Permalink
[WORKAROUND] Change jv.offset field to 32 bit size
Browse files Browse the repository at this point in the history 
Related issues:
  - Issue jqlang#1108  surprising bug if n > 65535
    jqlang#1108
  • Loading branch information
@h6ah4i
h6ah4i committed Nov 24, 2016
1 parent 0b82185 commit f43c520
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/jv.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ struct jv_refcnt;
typedef struct {
unsigned char kind_flags;
unsigned char pad_;
unsigned short offset; /* array offsets */
unsigned int offset; /* array offsets */
int size;
union {
struct jv_refcnt* ptr;
Expand Down

1 comment on commit f43c520

@nicowilliams
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing that changes the size of jv is desirable. Currently jv is 128 bits in size. That's a convenient and cheap size, and part of the original design. I suppose I could be talked into it, but I'd rather not, not yet.

Please sign in to comment.