Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing jQuery #2225

Merged
merged 6 commits into from
May 4, 2020
Merged

Removing jQuery #2225

merged 6 commits into from
May 4, 2020

Conversation

roblarsen
Copy link
Member

@roblarsen roblarsen commented Apr 28, 2020

Closes #2215

(I'll write up a super great commit message when I merge this in)

Additionally, this commit updates Modernizr (I was in the gulpfile and was reminded that they just released) I know! I know. Why not make a big change-set bigger, I always say.

to do

  • Tests!
  • Write it up! Both cleaning up the docs and writing up the reasoning.

Closes #2215

(I'll write up a super great commit message when I merge this in)

Additionally, this commit updates Modernizr (I was in the gulpfile and was reminded that they just released)
dist/doc/html.md Outdated Show resolved Hide resolved
dist/doc/html.md Outdated Show resolved Hide resolved
@roblarsen roblarsen removed the WIP label Apr 28, 2020
@roblarsen
Copy link
Member Author

  • Maybe put together a little script to add it back in on demand? It wouldn't be that bad. npm install, use variations on old gulp tasks to move it to dist and and then add the snippet back in. 🤔

I'm going to add a couple of gulp tasks for this kind of thing in a separate branch. I'm going to look at the docs again and then merge this in

@roblarsen roblarsen changed the title Removing jQuery (WIP) Removing jQuery May 4, 2020
@roblarsen
Copy link
Member Author

Pulling this in since it will end up, from a Docs perspective, being an interim step (more on that soon 🤔 )

@roblarsen roblarsen merged commit 1d2b155 into master May 4, 2020
@coliff coliff deleted the remove-jquery branch May 5, 2020 02:06
@lovetingyuan
Copy link

wow, awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update jQuery to 3.5.1 or... Remove jQuery? Discuss!
4 participants