Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SRI Hash for jQuery #1904

Merged
merged 3 commits into from
Nov 16, 2016
Merged

Add SRI Hash for jQuery #1904

merged 3 commits into from
Nov 16, 2016

Conversation

mik-laj
Copy link
Contributor

@mik-laj mik-laj commented Nov 12, 2016

Hi my friend,

I want add a new freature - generating SRI Hash for external depedencies from CDN.
You could read more about it on:
https://www.srihash.org/
https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity

It should be emphasized that the official website of jQuery supports this technology:
jquery/codeorigin.jquery.com#20

You should look at:
http://caniuse.com/#feat=subresource-integrity

Thanks in advance

@roblarsen
Copy link
Member

@mik-laj The tests are failing.

@mik-laj
Copy link
Contributor Author

mik-laj commented Nov 12, 2016

@roblarsen I do not have access to the logs. Could you show them to me?

@roblarsen
Copy link
Member

  1. You can run the tests locally (npm install, npm test)
  2. If you're on Github you're staring at the logs. Click on the "All checks have failed"

image

@mik-laj
Copy link
Contributor Author

mik-laj commented Nov 12, 2016

  1. Thanks bro. I fixed code:-)
  2. I have found logs. I did not use often matrix tests. I did not notice that I have something I have to click.

@roblarsen
Copy link
Member

@mik-laj that's what I'm here for.

@mik-laj
Copy link
Contributor Author

mik-laj commented Nov 12, 2016

Test passed

@roblarsen roblarsen merged commit 76baba6 into h5bp:master Nov 16, 2016
@roblarsen
Copy link
Member

THANKS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants