-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing comment regarding apple touch icon #1783
Comments
@nathanieloffer My understanding of that is that the apple touch icon is named explicitly and thus it doesn't need a comment on where to put it (like normalize.css or other resources) and that comment refers to a favicon because it isn't explicitly mentioned anywhere else than in that comment. I may be wrong but this is how I understand it. |
If the touch icon is the favcon then maybe comment should also mention this. |
Addition to last comment, the touch icon is used for web clipping on iOS, I guess a comment would be useful here for new developers |
These are two separate elements. They're related by being icons and by being next to each other, but they're two separate elements. Specifically, the comment isn't about the apple-touch-icon. The comment is an instruction about how to implement a favicon. favicon.ico is placed in the root directory because it's automatically requested by browsers. You don't need one in the source. The comment (in hindsight) is poor because presupposes that a developer expects to see |
You're right roblarsen I was expecting to see that line from days gone by. Hence my confusion regarding the comment. |
I'm going to close this. I'll update the docs. |
The image in the statement is named apple-touch-icon.png but the comment refers to favicon.ico. This should be changed to improve readability especially for new web developers.
<link rel="apple-touch-icon" href="apple-touch-icon.png">
<!-- Place favicon.ico in the root directory -->
The text was updated successfully, but these errors were encountered: