Fix crash when saving a Frame to CSV #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -464,6 +464,7 @@ size_t CsvWriter::estimate_output_size() | |||
| size_t ncols = static_cast<size_t>(dt->ncols); | |||
| size_t total_string_size = 0; | |||
| size_t total_columns_size = 0; | |||
| fixed_size_per_row = ncols; // 1 byte per separator | |||
There was a problem hiding this comment.
Do we also need to add 1 byte for \n?
There was a problem hiding this comment.
There are ncols-1 separators + 1 newline, ncols bytes in total.
There was a problem hiding this comment.
Right, for some reason thought we have an additional separator at the end.
abal5
pushed a commit
that referenced
this pull request
Sep 13, 2018
* Fix crash when saving a Frame to CSV * Do not spawn more threads than the number of chunks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash came because of mis-estimating the line length (forgot to account for the separators).
Closes #1278