Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key columns are not displayed properly in console widget #1672

Closed
st-pasha opened this issue Feb 20, 2019 · 0 comments · Fixed by #1676
Closed

Key columns are not displayed properly in console widget #1672

st-pasha opened this issue Feb 20, 2019 · 0 comments · Fixed by #1676
Assignees
@st-pasha
Labels
bug Any bugs / errors in datatable; however for severe bugs use [segfault] label
Milestone
Release 0.9.0

Comments

@st-pasha
Copy link
Contributor

When a frame has many columns and a viewport is moved to the right, the key columns should remain fixed (similar to Excel). Instead, they are shifted away together with other columns, and only their names are displayed. The end result is that the displayed column names do not match the actual columns they label.
@st-pasha st-pasha added the bug Any bugs / errors in datatable; however for severe bugs use [segfault] label label Feb 20, 2019
@st-pasha st-pasha added this to the Release 0.9.0 milestone Feb 20, 2019
@st-pasha st-pasha self-assigned this Feb 20, 2019
@st-pasha st-pasha mentioned this issue Feb 21, 2019
Merged
st-pasha added a commit that referenced this issue Feb 21, 2019
@st-pasha
Properly display keyed frame in console view (#1676)
0282c6f 
This PR fixes a bug where the key columns were not displayed quite right during scrolling in a console widget. Now they have proper appearance of "frozen" columns (similar to Excel).

In addition, `Frame._data_viewer()` method is removed; instead there is now a helper class `DatatableFrameConnector` that has the same purpose. The advantage of having it as a separate class is that we could in principle add more classes like this to implement connectors to other data frames as well.

Closes #1672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st-pasha st-pasha

Labels
bug Any bugs / errors in datatable; however for severe bugs use [segfault] label
Projects
None yet
Milestone
Release 0.9.0
Development

Successfully merging a pull request may close this issue.

Properly display keyed frame in console view h2oai/datatable
1 participant
@st-pasha