Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(#20): tmp file in to-json.test.js #91

Merged
merged 2 commits into from
Feb 6, 2025
Merged

bug(#20): tmp file in to-json.test.js #91

merged 2 commits into from
Feb 6, 2025

Conversation

h1alexbel
Copy link
Owner

@h1alexbel h1alexbel commented Feb 6, 2025

In this PR I've replaced real file creation in afterEach block with tmp file in order to gracefully clean up resources.

see #20
History:

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.75%. Comparing base (10509e8) to head (47970b2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   18.75%   18.75%           
=======================================
  Files          10       10           
  Lines         192      192           
  Branches       41       41           
=======================================
  Hits           36       36           
  Misses        156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h1alexbel
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 6, 2025

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit 47970b2 into master Feb 6, 2025
8 checks passed
@h1alexbel h1alexbel deleted the 20 branch February 6, 2025 08:51
@rultor
Copy link
Collaborator

rultor commented Feb 6, 2025

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 7min).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants