feat(#13, #9): --graphql, --schema #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rultor merge |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 9.35% 18.75% +9.39%
==========================================
Files 9 10 +1
Lines 171 192 +21
Branches 34 41 +7
==========================================
+ Hits 16 36 +20
- Misses 155 156 +1 ☔ View full report in Codecov by Sentry. |
@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here |
@h1alexbel Done! FYI, the full log is here (took me 22min) |
|
@rultor release, tag is |
@h1alexbel OK, I will release it now. Please check the progress here |
@h1alexbel Done! FYI, the full log is here (took me 21min) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull, I've introduced new CLI parameters:
--graphql,--schemafor dynamic query and parsing.closes #13
closes #9
History:
--graphqlfor graphql API query #13): --graphql--graphqlfor graphql API query #13): docs--graphqlfor graphql API query #13): repositoryCount tooPR-Codex overview
This PR focuses on refactoring the way GraphQL queries are handled in the project, moving from a hardcoded query string to reading the query from a file. It also introduces a new utility for accessing nested properties in objects and adds tests for these functionalities.
Detailed summary
queryintest/resources/query.graphql.src/graph.jsto read the GraphQL query from a file.nestedPropfunction insrc/nested-prop.jsfor accessing nested properties.graph.jsintest/graph.test.js.nestedPropintest/nested-prop.test.js.src/index.jsto utilize the new query reading method.README.mdto include new command-line options for GraphQL query and schema file paths.