Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#10): --json #17

Merged
merged 3 commits into from
May 22, 2024
Merged

feat(#10): --json #17

merged 3 commits into from
May 22, 2024

Conversation

h1alexbel
Copy link
Owner

@h1alexbel h1alexbel commented May 22, 2024

closes #10


PR-Codex overview

This PR adds configuration files, updates README instructions, and enhances file handling in the code.

Detailed summary

  • Added renovate.json, .rultor.yml, .pdd
  • Improved file handling in test/to-json.test.js
  • Updated README instructions for output file customization
  • Enhanced file output handling based on user input in src/index.js

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@h1alexbel
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented May 22, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented May 22, 2024

@rultor merge

@h1alexbel Oops, I failed. You can see the full log here (spent 7min)

up to date, audited 275 packages in 1s

46 packages are looking for funding
  run `npm fund` for details

5 vulnerabilities (1 moderate, 3 high, 1 critical)

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
\u001b[?25l(⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂) ⠴ idealTree:repo: sill idealTree buildDeps\u001b[0m\u001b[K
(⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂⠂) ⠦ idealTree:repo: sill idealTree buildDeps\u001b[0m\u001b[K
(#########⠂⠂⠂⠂⠂⠂⠂⠂⠂) ⠧ idealTree: timing idealTree Completed in 407ms\u001b[0m\u001b[K
(##################) ⠋ reify:@dprint/darwin-arm64: timing reifyNode:node_module\u001b[0m\u001b[K
(##################) ⠴ reify:@dprint/darwin-arm64: timing reifyNode:node_module\u001b[0m\u001b[K
(##################) ⠦ reify:@dprint/darwin-arm64: timing reifyNode:node_module\u001b[0m\u001b[K
(##################) ⠦ reify:@dprint/darwin-arm64: timing reifyNode:node_module\u001b[0m\u001b[K
(##################) ⠦ reify:@dprint/darwin-arm64: timing reifyNode:node_module\u001b[0m\u001b[K
(##################) ⠏ reify:@dprint/darwin-arm64: timing reifyNode:node_module\u001b[0m\u001b[K

\u001b[K\u001b[?25h
up to date, audited 275 packages in 1s

46 packages are looking for funding
  run `npm fund` for details

5 vulnerabilities (1 moderate, 3 high, 1 critical)

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> ghminer@0.0.0 test
> grunt --no-color

Running "mochacli:test" (mochacli) task

\u001b[0m\u001b[0m
\u001b[0m  Test case for compiled.js\u001b[0m
  \u001b[32m  ✓\u001b[0m\u001b[90m compiles query from parts\u001b[0m

\u001b[0m  Test case for to-json.js\u001b[0m
  \u001b[32m  ✓\u001b[0m\u001b[90m creates .json file and writes results as JSON\u001b[0m
  \u001b[31m  1) "after each" hook for "creates .json file and writes results as JSON"\u001b[0m

\u001b[0m  Test case for tokens.js\u001b[0m
test.json file saved
  \u001b[32m  ✓\u001b[0m\u001b[90m fetches one token from file\u001b[0m
  \u001b[32m  ✓\u001b[0m\u001b[90m fetches a few tokens from file\u001b[0m


\u001b[92m \u001b[0m\u001b[32m 4 passing\u001b[0m\u001b[90m (20ms)\u001b[0m
\u001b[31m  1 failing\u001b[0m

\u001b[0m  1) Test case for to-json.js
       "after each" hook for "creates .json file and writes results as JSON":
\u001b[0m\u001b[31m     Error: ENOENT: no such file or directory, unlink 'test.json'\u001b[0m\u001b[90m
      at Object.unlinkSync (node:fs:1881:3)
      at Context.<anonymous> (test/to-json.test.js:31:10)
      at process.processImmediate (node:internal/timers:476:21)
\u001b[0m


Warning:  Use --force to continue.

Aborted due to warnings.
container 5b7e1466cdfcb85ea5a83136f84faec066d2750834f0cf53bc8eaa8cb18bf33d is dead
Wed May 22 13:25:18 UTC 2024

@h1alexbel
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented May 22, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 4f6a9b1 into master May 22, 2024
4 checks passed
@rultor
Copy link
Collaborator

rultor commented May 22, 2024

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 7min)

@h1alexbel h1alexbel deleted the cli branch May 22, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add optional --json flag for on-demand saving of the mined result to JSON file
2 participants