Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(context): Switch to new context API #368

Closed
wants to merge 2 commits into from
Closed

refactor(context): Switch to new context API #368

wants to merge 2 commits into from

Conversation

obartra
Copy link
Collaborator

@obartra obartra commented Feb 3, 2018 •
edited
Loading

Context tests need to be updated

These changes require at least React 16.3 and remove the prop-types dependency

TODO

  • Fix tests
  • Check / Add story showcasing any context changes
  • Fix react props being passed down to DOM elements

BREAKING CHANGE

@obartra obartra force-pushed the obartra/new-context branch 7 times, most recently from 2e0c5ce to a4430c5 Compare February 4, 2018 19:11
@obartra obartra force-pushed the obartra/new-context branch 2 times, most recently from 633e21c to 8f6db08 Compare February 25, 2018 20:47
@obartra obartra force-pushed the obartra/new-context branch from 8f6db08 to dcb5354 Compare August 21, 2018 13:32
@obartra obartra force-pushed the obartra/new-context branch from dcb5354 to b00b771 Compare August 21, 2018 13:36
@obartra
Copy link
Collaborator Author

obartra commented Aug 29, 2018

Closing in favor of #391

@obartra obartra closed this Aug 29, 2018
@obartra obartra deleted the obartra/new-context branch August 29, 2018 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@obartra