Fix Memory leak #160
Merged
Fix Memory leak #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested livego continuously and the memory kept increasing, suggesting there was memory leak somewhere. The culprit was the stream not being deleted.
When the pushing ends s.isStart is set to false, which prevents the stream from being deleted, when CheckAlive()
livego/protocol/rtmp/stream.go
Line 369 in 12948df
is called. Specifically:
livego/protocol/rtmp/stream.go
Line 382 in 12948df
I also added writerClosed to flvWriter to prevent closing it twice.