Add Java 9 BigInteger constructors #9953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
reviewed
May 11, 2024
There was a problem hiding this comment.
In more closely looking at the Javadoc for BigInteger, I see there is another new constructor:
https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/math/BigInteger.html#%3Cinit%3E(int,byte%5B%5D,int,int)
There are also other new methods (sqrt, sqrtAndRemainder), and a new constant TWO. I'll make another issue for these new members, but as long as the other constructor is similar work, it seems worth adding now?
user/test/com/google/gwt/emultest/java/math/BigIntegerConstructorsTest.java
Outdated
Show resolved
Hide resolved
user/test/com/google/gwt/emultest/java/math/BigIntegerConstructorsTest.java
Outdated
Show resolved
Hide resolved
having a byte[] with zero length is allowed for constructor BigInteger(int signum, byte[] val, int offset, int length)
niloc132
reviewed
May 24, 2024
There was a problem hiding this comment.
Full build passed: https://github.com/vegegoku/gwt/actions/runs/9192280404
niloc132
changed the title
niloc132
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emulate the
BigInteger(byte[] bytes, int offset, int length)andBigInteger(int signum, byte[] magnitude, int offset, int length)constructors that were added in java 9.Fixes #9901