Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the problem if layout doesnt have static item #47

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

UTing1119
Copy link
Collaborator

Description

if layout doesn't have static item, it will throw a error about the layout is empty.
the example layout is the following:

{ h: 1, i: 1, w: 1, x: 0, y: 0 },
{ h: 1, i: 2, w: 1, x: 1, y: 0 },
{ h: 1, i: 3, w: 1, x: 2, y: 0 },
{ h: 1, i: 4, w: 1, x: 3, y: 0 },
{ h: 1, i: 5, w: 1, x: 4, y: 0 },
{ h: 1, i: 6, w: 1, x: 0, y: 1 },
{ h: 1, i: 7, w: 1, x: 1, y: 1 },
{ h: 1, i: 8, w: 1, x: 2, y: 1 },

it will cause error and prevent all action.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Owner

@gwinnem gwinnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete dead code before a pr is made next time.

@gwinnem gwinnem merged commit b83f0da into gwinnem:main Dec 27, 2023
@gwinnem gwinnem added this to the Release 1.2.7 milestone Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants