Skip to content

Commit

Permalink
feat: Add sequences defined by a formula in n to the main tool
Browse files Browse the repository at this point in the history
  This is done by creating and exporting a SequenceFormula class.

  In addition, adding this class seemed to spark an additional cascade
  of the Vue components needing to be (more) strongly typed. So the commit
  has numerous new type annotations (that should have no effect other than
  to aid TypeScript type checking) and a slight modification/simplification
  to the interface between sequences.ts and visualizers.ts on the one hand
  and ToolMain.vue on the other, since I could not figure out out to type
  the old interface (and a lot of extraneous information that was never
  being used was being passed anyway). Hopefully these changes will
  eliminate issue numberscope#28.

  Also, again as part of shoring up the typing, finally eliminates the
  spurious additional copy of the p5 code in src/assets, instead relying
  on npm install to get the proper copy of p5 in the right place. (The point
  being that the idiosyncratic copy was not typed, but npm brings in the
  type definitions automatically if you rely on it.)

  Resolves numberscope#14.
  • Loading branch information
gwhitney committed Oct 15, 2021
1 parent 40c4941 commit a72dbf2
Show file tree
Hide file tree
Showing 15 changed files with 354 additions and 116 deletions.
159 changes: 147 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"axios": "^0.21.1",
"core-js": "^3.6.4",
"jquery": "^3.4.1",
"mathjs": "^9.5.1",
"p5": "^1.0.0",
"router": "^1.3.5",
"vue": "^2.6.11",
Expand Down
3 changes: 0 additions & 3 deletions src/assets/p5.min.js

This file was deleted.

Loading

0 comments on commit a72dbf2

Please sign in to comment.