Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with '--all' argument #34

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Fix issues with '--all' argument #34

merged 2 commits into from
Nov 23, 2024

Conversation

Journeycorner
Copy link
Contributor

This pull request fixes two issues I had with using the '--all' argument with list-units():

  1. there was a deadlock, so the output would never arrive
  2. the output for units in the state 'not_found' was messed up, because the unit name is then prefixed by '● '

Use 'wait_with_output()' instead of 'wait()' fixes a deadlock,
which occurs on my machine with the '--all' argument and no
'--state' filters.
@Journeycorner
Copy link
Contributor Author

Fixed format.

@gwbres
Copy link
Owner

gwbres commented Nov 4, 2024

sorry apparently some stringent "clippy" rules are applied by CI/CD and by defaults.
it probably got added at some point in this project but I did not notice.

FYI, if you're not familiar with it already, you can apply clippy at compilation and have it "fix" the code right away. For that, you can take a look at the clippy.sh script in my https://github.com/georust/rinex/tools repo

@Journeycorner
Copy link
Contributor Author

sorry apparently some stringent "clippy" rules are applied by CI/CD and by defaults. it probably got added at some point in this project but I did not notice.

FYI, if you're not familiar with it already, you can apply clippy at compilation and have it "fix" the code right away. For that, you can take a look at the clippy.sh script in my https://github.com/georust/rinex/tools repo

Sounds reasonable. I applied the fix and force pushed.

@gwbres
Copy link
Owner

gwbres commented Nov 4, 2024

heading to bed, will fix that tomorrow morning

@Journeycorner
Copy link
Contributor Author

@gwbres my last commit should fix the clippy issue. Let me know if I can help.

Btw.: Your create was very useful to me for writing a GUI for systemd: https://github.com/Journeycorner/systemd-gtk. Thanks a lot! It currently uses the patched version of systemctl under the hood.

@gwbres gwbres merged commit 7220bf8 into gwbres:main Nov 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants