Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined plotifar #5034

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Combined plotifar #5034

wants to merge 4 commits into from

Conversation

tdent
Copy link
Contributor

@tdent tdent commented Feb 6, 2025

Addresses #5006

Standard information about the request

This is a: new feature

This change affects: the offline search

This change changes: result presentation / plotting

This change: follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines

Motivation

See #5006

Contents

Add a plotting script

Links to any issues or associated PRs

#5006 (again)

Testing performed

It produces a plot given exclude_zerolag files from a recent run with singles

Copy link
Contributor

@GarethCabournDavies GarethCabournDavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to this! A couple of comments, but I think this is close to being right.

parser.add_argument('--trigger-files', nargs='+',
help='Paths to separate-event-type statmap files.')
parser.add_argument('--ifo-combos', nargs='+',
help='Which event types (detector combinations) to plot.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to infer this from the trigger files? i.e. one ifo combo per trigger file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems not as straighforward to do it this way, as the combo list is used in digest_significance_options.

bin/plotting/pycbc_page_ifar_vs_stat Show resolved Hide resolved
bin/plotting/pycbc_page_ifar_vs_stat Outdated Show resolved Hide resolved
bin/plotting/pycbc_page_ifar_vs_stat Outdated Show resolved Hide resolved
bin/plotting/pycbc_page_ifar_vs_stat Outdated Show resolved Hide resolved
bin/plotting/pycbc_page_ifar_vs_stat Outdated Show resolved Hide resolved
bin/plotting/pycbc_page_ifar_vs_stat Outdated Show resolved Hide resolved
@tdent
Copy link
Contributor Author

tdent commented Feb 8, 2025

So .. atm I have this

        logging.info(f"Ifos {exc_zlag_f.attrs['ifos']}")  # eg 'H1 L1'
        event_ifos = exc_zlag_f.attrs['ifos'].split()  # eg ['H1', 'L1']
        sig_key = ''.join(event_ifos)  # eg 'H1L1'
        coinc_key = sig_key.replace('1', '')  # eg 'HL'

are all these different forms really needed ?

@tdent
Copy link
Contributor Author

tdent commented Feb 8, 2025

Seems I was able to do without event_ifos at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants