-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combined plotifar #5034
base: master
Are you sure you want to change the base?
Combined plotifar #5034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting to this! A couple of comments, but I think this is close to being right.
parser.add_argument('--trigger-files', nargs='+', | ||
help='Paths to separate-event-type statmap files.') | ||
parser.add_argument('--ifo-combos', nargs='+', | ||
help='Which event types (detector combinations) to plot.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to infer this from the trigger files? i.e. one ifo combo per trigger file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems not as straighforward to do it this way, as the combo list is used in digest_significance_options
.
So .. atm I have this
are all these different forms really needed ? |
Seems I was able to do without |
Addresses #5006
Standard information about the request
This is a: new feature
This change affects: the offline search
This change changes: result presentation / plotting
This change: follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
Motivation
See #5006
Contents
Add a plotting script
Links to any issues or associated PRs
#5006 (again)
Testing performed
It produces a plot given exclude_zerolag files from a recent run with singles