require pre-numpy 2.0 #4789
require pre-numpy 2.0 #4789
Conversation
|
Do we need to edit |
Co-authored-by: Tito Dal Canton <tito@dalcanton.it>
Yes, if we want it to work for python3.9. Once we drop that, we can actually build against 2.0 and it will work in numpy versions supported back to those using python3.10. They changed the way this works in numpy 2.0 to support backwards compatibility, but only to numpy versions that support the currently supported python version. |
|
Not sure why build is failing on python 3.11. Running a test just to make sure that is the case and there aren't failures on the other versions. I can't reproduce on my laptop with python3.11 (no failures there) so unfortunately I'm resorting to trying here. Any ideas? |
* Try to copy #4789 for v23_release_branch * Limit scipy version * Try this * Use monkeypatch for numpy's float deprecation
This pins to numpy < 2.0 while the transition is worked out. We'll need one final release with this requirement before switching to numpy 2.0 support.