Handle RA and dec in radians in pygrb #4787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ees in the summary table)
titodalcanton
approved these changes
Jun 17, 2024
GarethCabournDavies
pushed a commit
to GarethCabournDavies/pycbc
that referenced
this pull request
Jun 24, 2024
* Always handle RA and dec in radians (but keep displaying them in degrees in the summary table) * Better args in grb info table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply uses radians for right ascension and declination throughout PyGRB. Displaying them in degrees in the summary table on the results webpage is preserved. This cleanup fixes the single IFO vs coherent IFO diagnostic plots.
Standard information about the request
This is a: bug fix
This change affects: PyGRB
This change changes: result presentation / plotting
Motivation
The injections in plots such as
with 2 IFOs or
with 3 IFOs look wrong, but otherwise the behaviour of injections looks good. The PR ensures that R.A. and declination are handled consistently throughout the workflow, so that the resulting plots are now correspondingly
and
Testing performed
The updated plots were produced rerunning the entire workflow from injection production onwards (injection filtering, post-processing).