Truncate SNR/FAR for live pastro calcs #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One small comment but otherwise this looks good to me. Is there more coming? Should I test this at IJCLab? Also please rebase on master. |
Merge changes from master
|
Hopefully the return logic is still correct after 'negation', please check .. |
|
Testing at IJCLab. |
titodalcanton
approved these changes
Mar 9, 2023
titodalcanton
pushed a commit
that referenced
this pull request
Mar 17, 2023
* Truncate SNR/FAR for live pastro calcs * codecliming * reverse branch logic to return sooner * fix indent/codeclimate
yi-fan-wang
pushed a commit
to yi-fan-wang/pycbc
that referenced
this pull request
May 30, 2023
* Truncate SNR/FAR for live pastro calcs * codecliming * reverse branch logic to return sooner * fix indent/codeclimate
yi-fan-wang
pushed a commit
to yi-fan-wang/pycbc
that referenced
this pull request
Jun 1, 2023
* Truncate SNR/FAR for live pastro calcs * codecliming * reverse branch logic to return sooner * fix indent/codeclimate
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
* Truncate SNR/FAR for live pastro calcs * codecliming * reverse branch logic to return sooner * fix indent/codeclimate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will require changes / additional info in the .json config file for the live p astro calculation, eg
for a limiting FAR of (just over) 1/100yr and SNR of 12.