Lisa dev merge #4128
Merged
Lisa dev merge #4128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugin testing script
ahnitz
reviewed
Sep 12, 2022
ahnitz
reviewed
Sep 12, 2022
ahnitz
reviewed
Sep 12, 2022
ahnitz
reviewed
Sep 12, 2022
ahnitz
reviewed
Sep 12, 2022
…eform being used.
…r waveforms whcih compute own det response
ahnitz
reviewed
Sep 13, 2022
ahnitz
reviewed
Sep 13, 2022
ahnitz
reviewed
Sep 13, 2022
ahnitz
reviewed
Sep 13, 2022
ahnitz
reviewed
Sep 13, 2022
ahnitz
reviewed
Sep 13, 2022
ahnitz
reviewed
Sep 13, 2022
ahnitz
reviewed
Sep 13, 2022
… returning data as dict with their data and channel name
…nto lisa_dev_merge Shichao adding doc tests onto his remote.
ahnitz
reviewed
Sep 14, 2022
pycbc/inference/models/relbin.py
Outdated
| @@ -181,6 +190,10 @@ def __init__( | |||
| # store fiducial waveform params | |||
| self.fid_params = self.static_params.copy() | |||
| self.fid_params.update(fiducial_params) | |||
|
|
|||
| if self.no_det_response: | |||
ahnitz
reviewed
Sep 14, 2022
pycbc/inference/models/relbin.py
Outdated
| **self.fid_params) | ||
|
|
||
| if self.no_det_response: | ||
| if ifo not in self.no_det_waves: |
There was a problem hiding this comment.
'no_det_waves' is never used, so is this needed?
ahnitz
reviewed
Sep 14, 2022
pycbc/inference/models/relbin.py
Outdated
| hh = 0.0 | ||
| hd = 0j | ||
| norm = 0.0 | ||
| filter = 0j |
There was a problem hiding this comment.
'filter' is a reserved name by python, so we try to avoid overloading it new code.
connor-mcisaac
pushed a commit
to connor-mcisaac/pycbc
that referenced
this pull request
Oct 12, 2022
* fix waveform_transforms not defined issue * add static_args back * fix cc issues * adopt Ian's changes for LISA * update for LISA bank * fix self.ta[ifo] issue * fix * fix ta issue * remove all changes * Plugin testing script * remove all hard-coded "BBHx" * Rel bug fix * Begin no atenna response wf interface * remove old bbhx plugin * add general interface for BBHx * is_lisa issue not fix yet * Adding test scripts * Plot code for inference * Approximant name change * Changed is_lisa flag to checking approximant name against type of waveform being used. * Modified cython code with own version of likelihood_parts function for waveforms whcih compute own det response * Error in changing to dictionary output from plugin * Fixes to PR request. Mainly reconfiguring due to convention choice of returning data as dict with their data and channel name * Code rename conventions * Changes from codeclimate * More codeclimate changes * More codeclimate changes Co-authored-by: WuShichao <wushichao@mail.bnu.edu.cn>
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
* fix waveform_transforms not defined issue * add static_args back * fix cc issues * adopt Ian's changes for LISA * update for LISA bank * fix self.ta[ifo] issue * fix * fix ta issue * remove all changes * Plugin testing script * remove all hard-coded "BBHx" * Rel bug fix * Begin no atenna response wf interface * remove old bbhx plugin * add general interface for BBHx * is_lisa issue not fix yet * Adding test scripts * Plot code for inference * Approximant name change * Changed is_lisa flag to checking approximant name against type of waveform being used. * Modified cython code with own version of likelihood_parts function for waveforms whcih compute own det response * Error in changing to dictionary output from plugin * Fixes to PR request. Mainly reconfiguring due to convention choice of returning data as dict with their data and channel name * Code rename conventions * Changes from codeclimate * More codeclimate changes * More codeclimate changes Co-authored-by: WuShichao <wushichao@mail.bnu.edu.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added options for plugin waveforms that compute their own arm response within the fd_seqeuence framework. Hard coded options for LISA detector within relbin.py for inference. Next step is to remove the LISA detector flags and generalise to all waveforms that compute their own arm response.