Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin numpy version #3646

Merged
merged 9 commits into from
Feb 26, 2021
Merged

unpin numpy version #3646

merged 9 commits into from
Feb 26, 2021

Conversation

ahnitz
Copy link
Member

@ahnitz ahnitz commented Feb 23, 2021

No description provided.

@ahnitz ahnitz requested a review from spxiwh February 23, 2021 13:24
@ahnitz
Copy link
Member Author

ahnitz commented Feb 23, 2021

@spxiwh I think we can now unpin numpy again with the latest lalsuite release. It should avoid the segfault issues that were observed before.

@ahnitz
Copy link
Member Author

ahnitz commented Feb 23, 2021

@spxiwh To help with this I've always switched out pyproject.toml to use scipy's metapackage for setting which version of numpy to build against.

see
https://pypi.org/project/oldest-supported-numpy/

@ahnitz ahnitz mentioned this pull request Feb 23, 2021
@ahnitz
Copy link
Member Author

ahnitz commented Feb 23, 2021

Ok, maybe using the 'oldest-supported-numpy' package won't work. Darn.

@ahnitz
Copy link
Member Author

ahnitz commented Feb 23, 2021

@spxiwh I also took the opportunity to fix an issue with the pyproject.toml. If someone is installing from there, we should use the oldest version of numpy possible which is compatible / available in wheel form. This is to ensure the best compatibility if someone uses an older numpy that it happens to build against. I tried using scipy's metapackage for this, but we require newer versions in some places, so I've put the information in by hand with a note to future self on what to remember if we need to modify this file again.

@spxiwh spxiwh merged commit 3e4ea07 into gwastro:master Feb 26, 2021
Moz-Port pushed a commit to Moz-Port/pycbc that referenced this pull request Mar 8, 2021
* unpin numpy version

* test

* always recreate tox env

* wrong way around

* nvm

* use minimum numpy version when building wheel

* also add catchall

* future is unpinned

* fix typo
dethodav pushed a commit to dethodav/pycbc that referenced this pull request Apr 13, 2021
* unpin numpy version

* test

* always recreate tox env

* wrong way around

* nvm

* use minimum numpy version when building wheel

* also add catchall

* future is unpinned

* fix typo
dethodav pushed a commit to dethodav/pycbc that referenced this pull request Apr 26, 2021
* unpin numpy version

* test

* always recreate tox env

* wrong way around

* nvm

* use minimum numpy version when building wheel

* also add catchall

* future is unpinned

* fix typo
dethodav pushed a commit to dethodav/pycbc that referenced this pull request Apr 26, 2021
* unpin numpy version

* test

* always recreate tox env

* wrong way around

* nvm

* use minimum numpy version when building wheel

* also add catchall

* future is unpinned

* fix typo
OliverEdy pushed a commit to OliverEdy/pycbc that referenced this pull request Apr 3, 2023
* unpin numpy version

* test

* always recreate tox env

* wrong way around

* nvm

* use minimum numpy version when building wheel

* also add catchall

* future is unpinned

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants