-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unpin numpy version #3646
unpin numpy version #3646
Conversation
@spxiwh I think we can now unpin numpy again with the latest lalsuite release. It should avoid the segfault issues that were observed before. |
@spxiwh To help with this I've always switched out pyproject.toml to use scipy's metapackage for setting which version of numpy to build against. |
Ok, maybe using the 'oldest-supported-numpy' package won't work. Darn. |
@spxiwh I also took the opportunity to fix an issue with the pyproject.toml. If someone is installing from there, we should use the oldest version of numpy possible which is compatible / available in wheel form. This is to ensure the best compatibility if someone uses an older numpy that it happens to build against. I tried using scipy's metapackage for this, but we require newer versions in some places, so I've put the information in by hand with a note to future self on what to remember if we need to modify this file again. |
* unpin numpy version * test * always recreate tox env * wrong way around * nvm * use minimum numpy version when building wheel * also add catchall * future is unpinned * fix typo
* unpin numpy version * test * always recreate tox env * wrong way around * nvm * use minimum numpy version when building wheel * also add catchall * future is unpinned * fix typo
* unpin numpy version * test * always recreate tox env * wrong way around * nvm * use minimum numpy version when building wheel * also add catchall * future is unpinned * fix typo
* unpin numpy version * test * always recreate tox env * wrong way around * nvm * use minimum numpy version when building wheel * also add catchall * future is unpinned * fix typo
* unpin numpy version * test * always recreate tox env * wrong way around * nvm * use minimum numpy version when building wheel * also add catchall * future is unpinned * fix typo
No description provided.