Properly record maxl phase in HM marginalized model #3644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnitz
approved these changes
Feb 23, 2021
Moz-Port
pushed a commit
to Moz-Port/pycbc
that referenced
this pull request
Mar 8, 2021
dethodav
pushed a commit
to dethodav/pycbc
that referenced
this pull request
Apr 13, 2021
dethodav
pushed a commit
to dethodav/pycbc
that referenced
this pull request
Apr 26, 2021
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MarginalizedHMPolPhaserecords the max likelihood phase asmaxl_phase, but this isn't being included in the returnedcurrent_statsbecause the_extra_statscall itmax_phase. This fixes that.