-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add search workflow run with condor + pegasus to github actions #3554
Conversation
@spxiwh I believe this is now ready for review. If you don't too strongly object, I think it might be nice to merge this before #3535. It would be a good test case to see this run there. This adds a new github action workflow which runs a "full" (as in the complete set of jobs) 3-ifo search workflow on the time around GW170814. It's using a reduce template bank and all other settings tuned to minimal configurations (i.e. fewest possible things for the followup codes to look at). It does however still use the proper detection statistic to make sure that path is exercised. Software injections are also done. Note that only the IMRPhenomD waveform model is employed, however, so we are not testing the various possible injection types or template approximants here. Things to note
Summary of other changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a couple of comments, and one place I'd like Gareth to double check.
I am a little concerned that having the config files here will mean that those in pycbc-config will not be updated ... But the ones here do need to be sufficiently different.
if len(indiv_segs) > 1: | ||
foreground_segs = np.sum(list(indiv_segs.values()), axis=0) | ||
else: | ||
foreground_segs = indiv_segs.values()[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GarethDaviesGW Can you check this. I think this is equivalent, but don't understand why this was complicated previously?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why this was over-complicated in this way - I don't see how this wouldn't work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and the proposed solution looks correct as well (This was probably early on in my understanding of segmentlists)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that taking the length is actually wrong as it is a dict. It was meant to avoid the case where there is a single segment as there the numpy sum will return a numpy ndarray instead of a segment list..
…tro#3554) * Add github action test with full run of search workflow * decode issues * Update pycbc_add_statmap
No description provided.