Remove old coinc workflow #3544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(This may need to be merged without squashing to ensure git preserves the history of the new coinc workflow executable). |
|
@ahnitz I will look over the documentation (in |
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
* Remove all old code and rename new code * Remove the old coinc workflow * Update workflow to rename codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A second part we can pull off of #3535 now is to remove the old all-sky workflow code. As well as removing the executable, and renaming the old one (as originally agreed), I remove the old code in
coincidence.pyand rename the new code.... I will note that I'm not going to do exhaustive tests on these branches. I will properly test #3535 though, so it is possible that some issues will creep in between merging the first of these commits and merging everything in #3535. Folks are encouraged to do any all-sky work from released code until this completes! (I can branch the current release and cherry pick on to there if we do want to update the current release ... We did that in the v1.11 release branch for similar reasons).