Fix empty plots in minifollowups #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spxiwh
approved these changes
Oct 23, 2020
ArthurTolley
pushed a commit
to ArthurTolley/pycbc
that referenced
this pull request
Nov 14, 2022
* Changes in pycbc_injection_minifollowup * 2nd change * 3rd change Co-authored-by: Marion Pillas Boissonnet <marionpillasboissonnet@client-172-18-72-200.clients.u-psud.fr>
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
* Changes in pycbc_injection_minifollowup * 2nd change * 3rd change Co-authored-by: Marion Pillas Boissonnet <marionpillasboissonnet@client-172-18-72-200.clients.u-psud.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that, in rare occasions, the single-template plots in the injection minifollowups are empty. This appears to be due to the fact that pycbc_injection_minifollowup compares the injection merger time to the science segments (instead of the analyzed segments) when setting up single-template plots. This pull request fixes the issue, and it also uses the injection merger time at the detector instead of the geocenter.