Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core collapse supernovae #3485

Merged
merged 8 commits into from
Oct 9, 2020
Merged

Conversation

chaitanyaafle
Copy link
Contributor

This patch adds the core-collapse waveform model:

  1. Added core bounce and post bounce waveform for core collapse supernovae. This uses a .hdf file containing principal component basis vectors to generate the waveforms. The principal components are generated using singular value decomposition of a catalog of numerical simulations. The waveform model is h = a_1 * x_1 + a_2 * x_2 + ... + a_n * x_n, where x_i are the principal component basis vectors and a_i are their coefficients.

  2. Added a constraint for the coefficients of the basis vectors that generate the core collapse waveform. The coefficients should be inside the two/three dimensional convex hull of the coefficients of the waveforms in a catalog.

  3. For Bayesian inference, the coefficients are the variable parameters while the principal components and the number of principal components used are static parameters. Following is an example section of .ini file that would be used for inference:

[variable_params]
coeff_0 = 
coeff_1 = 
coeff_2 = 
coeff_3 = 

[static_params]
distance = 0.0081
no_of_pcs = 9
principal_components_file = /path/to/principal_components_file.hdf 

[constraint-hull]
name = supernovae_convex_hull
principal_components_file = ${static_params|principal_components_file}
hull_dimention = 3
constraint_arg =

@cdcapano cdcapano self-requested a review October 2, 2020 14:48
@cdcapano cdcapano self-assigned this Oct 2, 2020
Copy link
Contributor

@cdcapano cdcapano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chaitanyaafle . I have a few requests. Also, please address the PEP-8 issues picked up by code climate.

pycbc/distributions/constraints.py Outdated Show resolved Hide resolved
pycbc/distributions/constraints.py Outdated Show resolved Hide resolved
pycbc/distributions/constraints.py Show resolved Hide resolved
pycbc/distributions/constraints.py Outdated Show resolved Hide resolved
pycbc/waveform/supernovae.py Outdated Show resolved Hide resolved
Copy link
Contributor

@cdcapano cdcapano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @chaitanyaafle

@cdcapano cdcapano merged commit d801bc1 into gwastro:master Oct 9, 2020
ArthurTolley pushed a commit to ArthurTolley/pycbc that referenced this pull request Nov 14, 2022
* made changes to gaussian_model.py and created supernovae.py in waveforms

* Added core bounce waveform; convex hull constraint

* Undo the changes made in gaussian_noise.py

* removed rebase comments; removed whitespaces

* Changed name to SupernovaeConvexHull; created __init__ to construct the hull within SupernovaeConvexHull

* Made some PEP8 friendly changes

* using  to read the principal component file

* Reduced line lengths
OliverEdy pushed a commit to OliverEdy/pycbc that referenced this pull request Apr 3, 2023
* made changes to gaussian_model.py and created supernovae.py in waveforms

* Added core bounce waveform; convex hull constraint

* Undo the changes made in gaussian_noise.py

* removed rebase comments; removed whitespaces

* Changed name to SupernovaeConvexHull; created __init__ to construct the hull within SupernovaeConvexHull

* Made some PEP8 friendly changes

* using  to read the principal component file

* Reduced line lengths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants