-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core collapse supernovae #3485
Merged
Merged
Core collapse supernovae #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa554f7
to
a0b1a4d
Compare
cdcapano
requested changes
Oct 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chaitanyaafle . I have a few requests. Also, please address the PEP-8 issues picked up by code climate.
cdcapano
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @chaitanyaafle
ArthurTolley
pushed a commit
to ArthurTolley/pycbc
that referenced
this pull request
Nov 14, 2022
* made changes to gaussian_model.py and created supernovae.py in waveforms * Added core bounce waveform; convex hull constraint * Undo the changes made in gaussian_noise.py * removed rebase comments; removed whitespaces * Changed name to SupernovaeConvexHull; created __init__ to construct the hull within SupernovaeConvexHull * Made some PEP8 friendly changes * using to read the principal component file * Reduced line lengths
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
* made changes to gaussian_model.py and created supernovae.py in waveforms * Added core bounce waveform; convex hull constraint * Undo the changes made in gaussian_noise.py * removed rebase comments; removed whitespaces * Changed name to SupernovaeConvexHull; created __init__ to construct the hull within SupernovaeConvexHull * Made some PEP8 friendly changes * using to read the principal component file * Reduced line lengths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the core-collapse waveform model:
Added core bounce and post bounce waveform for core collapse supernovae. This uses a
.hdf
file containing principal component basis vectors to generate the waveforms. The principal components are generated using singular value decomposition of a catalog of numerical simulations. The waveform model is h = a_1 * x_1 + a_2 * x_2 + ... + a_n * x_n, where x_i are the principal component basis vectors and a_i are their coefficients.Added a constraint for the coefficients of the basis vectors that generate the core collapse waveform. The coefficients should be inside the two/three dimensional convex hull of the coefficients of the waveforms in a catalog.
For Bayesian inference, the coefficients are the variable parameters while the principal components and the number of principal components used are static parameters. Following is an example section of
.ini
file that would be used for inference: