Fix typo in example workflow config and other cleanup #3480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurTolley
pushed a commit
to ArthurTolley/pycbc
that referenced
this pull request
Nov 14, 2022
* fix typo in workflow config, add no-create-proxy to submit dax command * remove old inference workflow files
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
* fix typo in workflow config, add no-create-proxy to submit dax command * remove old inference workflow files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a typo in the example workflow config files caught by Alex Brown. Source frame masses should be multiplied by the redshift to get detector frame mass, not divided. Also adds
--no-create-proxyto the examplepycbc_submit_daxcommand (that should of been there in the first place). Finally, this removes old workflow config files that are out of date and no longer used anywhere.