Removal of a manual list of trigger times #3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spxiwh
approved these changes
Sep 30, 2020
yes, sorry but testing this on proprietary data so can't post here. We have some large tails in the coincident background, which look like we would normally expect from the little-dogs of signals, which are coming from single-detector triggers. after this change, we remove the tails as the single-detector trigger is not forming little-dogs |
tdent
reviewed
Sep 30, 2020
| @@ -68,6 +68,10 @@ parser.add_argument('--hierarchical-removal-against', type=str, | |||
| 'triggers that are louder than either the "inclusive"' | |||
| ' (little-dogs-in) background, or the "exclusive" ' | |||
| '(little-dogs-out) background. [default="none"]') | |||
| parser.add_argument('--additional-event-times', type=float, nargs="+", | |||
| help="Additional event times which will be removed from " | |||
There was a problem hiding this comment.
if you want several times should they be space- or comma-separated? maybe indicate this in the help message?
ArthurTolley
pushed a commit
to ArthurTolley/pycbc
that referenced
this pull request
Nov 14, 2022
* start adding things to manually remove triggers from analysis * fix miscalled module, add some logging * correct page_snrifar help message
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
* start adding things to manually remove triggers from analysis * fix miscalled module, add some logging * correct page_snrifar help message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have signals in a single detector, it causes significant little-dog background.
This change means we can remove these triggers manually (or a bad glitch, or whatever, just pointing to a time) from all backgrounds