Update ringdown format_lmns to accept whitespace-separated string. #3454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JulianWesterweck Looks good to me! Have you tested it? I am not sure if we might need some |
|
Yes, I tested it, both loading a model that uses the waveform, to make sure it is read correctly from a config file, and by just using the generator directly. So far that worked. |
|
@JulianWesterweck It's minor, but could you fix the whitespace issues that code climate picked up? Other than that, @micamu do you have any objections to this being merged? |
ArthurTolley
pushed a commit
to ArthurTolley/pycbc
that referenced
this pull request
Nov 14, 2022
…wastro#3454) * Update ringdown format_lmns to accept whitespace-separated string. * Remove unnecessary whitespace.
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
…wastro#3454) * Update ringdown format_lmns to accept whitespace-separated string. * Remove unnecessary whitespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the list of desired ringdown modes a string prevents issues with conflicting dimensions in the FieldArray of parameters.