Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make start file from dynesty output #3444

Merged
merged 7 commits into from
Oct 2, 2020
Merged

make start file from dynesty output #3444

merged 7 commits into from
Oct 2, 2020

Conversation

ahnitz
Copy link
Member

@ahnitz ahnitz commented Sep 9, 2020

No description provided.

@ahnitz ahnitz requested a review from cdcapano September 9, 2020 13:41
@ahnitz
Copy link
Member Author

ahnitz commented Sep 11, 2020

This should be made to use the standard file handling so any file which can produce posterior samples can be used. Putting work in progress label in place until that is done.

cdcapano
cdcapano requested changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@cdcapano cdcapano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few requests to generalize the output a bit. This isn't emcee_pt specific; it could be used with any MCMC sampler. See my comments.

bin/inference/pycbc_inference_start_from_dynesty Outdated Show resolved Hide resolved
bin/inference/pycbc_inference_start_from_dynesty Outdated Show resolved Hide resolved
bin/inference/pycbc_inference_start_from_dynesty Outdated Show resolved Hide resolved
bin/inference/pycbc_inference_start_from_dynesty Outdated Show resolved Hide resolved
bin/inference/pycbc_inference_start_from_dynesty Outdated Show resolved Hide resolved
bin/inference/pycbc_inference_start_from_dynesty Outdated Show resolved Hide resolved
@ahnitz
Copy link
Member Author

ahnitz commented Oct 2, 2020

@cdcapano I believe all the comments have been addressed. Can you review again?

cdcapano
cdcapano requested changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@cdcapano cdcapano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for generalizing. See comments.

bin/inference/pycbc_inference_start_from_samples Show resolved Hide resolved
bin/inference/pycbc_inference_start_from_samples Outdated Show resolved Hide resolved
bin/inference/pycbc_inference_start_from_samples Outdated Show resolved Hide resolved
bin/inference/pycbc_inference_start_from_samples Outdated Show resolved Hide resolved
cdcapano
cdcapano approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@cdcapano cdcapano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@ahnitz ahnitz merged commit c2dc94d into gwastro:master Oct 2, 2020
ArthurTolley pushed a commit to ArthurTolley/pycbc that referenced this pull request Nov 14, 2022
@ahnitz @ArthurTolley
make start file from dynesty output (gwastro#3444)
f60323f 
* script to convert dynesty to emcee_pt_file

* test

* update

* update

* fixes

* update

* fixes
OliverEdy pushed a commit to OliverEdy/pycbc that referenced this pull request Apr 3, 2023
@ahnitz @OliverEdy
make start file from dynesty output (gwastro#3444)
d789b88 
* script to convert dynesty to emcee_pt_file

* test

* update

* update

* fixes

* update

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdcapano cdcapano cdcapano approved these changes

Assignees

@cdcapano cdcapano

Labels
inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahnitz @cdcapano