improvements to pycbc_make_skymap #3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahnitz
commented
Aug 12, 2020
ahnitz
commented
- Don't hard code template flow. It was forced to 27Hz always!!! Instead set to provided low frequency cutoff
- Don't hard code segment length, instead base on mass parameters given and f_low
- Don't hard code the approximant, allow to be selected
titodalcanton
approved these changes
Aug 12, 2020
lenona
pushed a commit
to lenona/pycbc
that referenced
this pull request
Sep 14, 2020
* make it easier to just get the losc strain channel * less inobvious hard coding in pycbc make skymap * fixes
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
* make it easier to just get the losc strain channel * less inobvious hard coding in pycbc make skymap * fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.