Created option to set a high-frequency cutoff in pycbc_make_skymap #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: -Added a --f-upper option to pycbc_make_skymap. It passes those to pycbc_make_single template and SingleCoincForGraceDB. -Added high-frequency cutoff to SingleCoincForGraceDB. PSDs may now be truncated at a high-frequency cutoff.
ahnitz
requested changes
Aug 11, 2020
There was a problem hiding this comment.
@MarlinSchaefer See the other comments, but the biggest one is that we need to pass the final cutoff information. You can do this by adding keys to the coinc_results dict which is passed to the SnglCoinc class.
I think you need to add the following key for each ifo being considered.
'foreground/IFO/f_final' where IFO should be replaced with the actual ifo.
If the key is passed correctly it will set the table entry at this line automatically https://github.com/gwastro/pycbc/blob/master/pycbc/io/live.py#L184
pycbc_make_skymap. Changes: -Reverted changes to pycbc/io/live.py -Made sure --f-upper option in pycbc_make_skymap is optional -Passing upper frequency limit to BAYSTAR via coinc_result
|
@MarlinSchaefer It looks like you've addressed the specific comments we had. |
ahnitz
approved these changes
Aug 12, 2020
lenona
pushed a commit
to lenona/pycbc
that referenced
this pull request
Sep 14, 2020
…wastro#3414) * Started adding high-frequency cutoff. * Implemented high-frequency cutoffs. Changes: -Added a --f-upper option to pycbc_make_skymap. It passes those to pycbc_make_single template and SingleCoincForGraceDB. -Added high-frequency cutoff to SingleCoincForGraceDB. PSDs may now be truncated at a high-frequency cutoff. * Wrapped lines for CodeClimate. * Finished implementing a high-frequency cutoff for pycbc_make_skymap. Changes: -Reverted changes to pycbc/io/live.py -Made sure --f-upper option in pycbc_make_skymap is optional -Passing upper frequency limit to BAYSTAR via coinc_result
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
…wastro#3414) * Started adding high-frequency cutoff. * Implemented high-frequency cutoffs. Changes: -Added a --f-upper option to pycbc_make_skymap. It passes those to pycbc_make_single template and SingleCoincForGraceDB. -Added high-frequency cutoff to SingleCoincForGraceDB. PSDs may now be truncated at a high-frequency cutoff. * Wrapped lines for CodeClimate. * Finished implementing a high-frequency cutoff for pycbc_make_skymap. Changes: -Reverted changes to pycbc/io/live.py -Made sure --f-upper option in pycbc_make_skymap is optional -Passing upper frequency limit to BAYSTAR via coinc_result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional argument to pycbc_make_skymap.
This argument is passed to pycbc_single_template and SingleCoincForGraceDB.
For SingleCoincForGraceDB to accept a high-frequency cutoff changes to pycbc/io/live.py were required. I think the place I put these changes at don't interfere with anything else. I also think that implementing the high-frequency cutoff the way done here will pass it to Baystar.