Fixes to live combine trigger fits #3391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(And no rush on this - obviously paper takes precedence) |
|
I cannot speak for the functionality (I assume you tested it), but modulo the comment above this looks good. |
GarethCabournDavies
force-pushed
the
combine_trigger_fits
branch
from
912bf15 to
ee0a1b4
Compare
|
@GarethDaviesGW @titodalcanton What's the status of this? |
|
I think I still have an open question to @GarethDaviesGW about the correctness of the regexp. |
|
That's right - I had just forgotten about this. I'll implement Tito's
suggestion and then merge
…On Sat, 19 Sep 2020, 13:45 Tito Dal Canton, ***@***.***> wrote:
I think I still have an open question to @GarethDaviesGW
<https://github.com/GarethDaviesGW> about the correctness of the regexp.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3391 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKTQKRXJF2ZS6WMLEOJFHCDSGSRXTANCNFSM4PFQ3V6A>
.
|
|
(well I'll merge after approval) |
|
oops - that was the wrong button |
titodalcanton
approved these changes
Sep 22, 2020
…unused import and fix regex
GarethCabournDavies
force-pushed
the
combine_trigger_fits
branch
from
11a2493 to
82398d8
Compare
ArthurTolley
pushed a commit
to ArthurTolley/pycbc
that referenced
this pull request
Nov 14, 2022
* be less proscriptive with date format * fix issues if no triggers in a bin - ensure ifar = 0 in this case
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
* be less proscriptive with date format * fix issues if no triggers in a bin - ensure ifar = 0 in this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow date format to not be YYYY_MM_DD, but (e.g.) YYYY_M_D
fix issue which would break things if no triggers are found in the duration bin
Note that this does not affect the validity of reviews - it is mostly due to dealing with the O2 triggers