Add gate and paint function #3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 10, 2020 19:53
ahnitz
approved these changes
Jul 10, 2020
lenona
pushed a commit
to lenona/pycbc
that referenced
this pull request
Sep 14, 2020
* add gate and paint function * add option to copy * Update gate.py Co-authored-by: Alex Nitz <alex.nitz@gmail.com>
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
* add gate and paint function * add option to copy * Update gate.py Co-authored-by: Alex Nitz <alex.nitz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the gate and in-paint function used by the IAS group to the gate module. It just takes a right index and left index. We probably will want to add another function that takes in times, but since that may require doing sub-sample shifting, I thought it might be better to add that as a separate function, which would call this function.
I've only tested that this works on a time series without failing. I haven't actually checked that it gives reasonable results.