Changes in arm length value #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnitz
reviewed
Jul 10, 2020
pycbc/detector.py
Outdated
| n = np.array(range(1, 4)) | ||
| kappa, _lambda_ = 0, 0 | ||
| alpha = 2. * np.pi * ref_time/1 + kappa | ||
| beta_n = (n - 1) + (2. * np.pi/3) + _lambda_ | ||
| a, L = 1., .1 | ||
| a, L = 1., 0.0334229 |
There was a problem hiding this comment.
If possible, can you add a reference for some of these numbers? @SSingh087
For equal arm length 0.03 AU
ahnitz
approved these changes
Jul 15, 2020
lenona
pushed a commit
to lenona/pycbc
that referenced
this pull request
Sep 14, 2020
* Changes in arm length value * Changes in the equation of the orbit For equal arm length 0.03 AU
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
* Changes in arm length value * Changes in the equation of the orbit For equal arm length 0.03 AU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction in values of time
Correction in the calculation of position