Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass boundary types to dynesty #3364

Merged
merged 4 commits into from
Jul 10, 2020
Merged

pass boundary types to dynesty #3364

merged 4 commits into from
Jul 10, 2020

Conversation

ahnitz
Copy link
Member

@ahnitz ahnitz commented Jul 9, 2020

This passes the pycbc boundary types (where applicable) to dynest. Only the two-sided reflective and the cyclic boundaries are supported as those are the only ones Dynesty has. So, notable, there is no one-sided reflective boundary.

Example of how to write the boundary in the config file. Note that if you specify the boundary type, you also need to explicitly
set the min/max of the parameter as well. I am doing so here for inclination. The units are currently radians per PI, but that will change to PI in #3355, so be careful until that patch is applied.

#btype-min-distance = reflected
#btype-max-distance = reflected


[prior-inclination]	[prior-inclination]
name = sin_angle	name = sin_angle
cyclic-inclination =
min-inclination = 0
max-inclination = 3.141592653

@ahnitz ahnitz requested review from cdcapano and a-r-williamson July 9, 2020 19:49
@ahnitz
Copy link
Member Author

ahnitz commented Jul 9, 2020

For sanity, let's say this depends on #3355

Copy link
Contributor

@cdcapano cdcapano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know Dynesty supported cyclic and reflected boundaries. Finally, a use for them! Anyway, looks good.

Copy link
Contributor

@a-r-williamson a-r-williamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, thanks.

@ahnitz ahnitz merged commit 5685400 into gwastro:master Jul 10, 2020
lenona pushed a commit to lenona/pycbc that referenced this pull request Sep 14, 2020
* hook up boundary types to dynesty

* nc

* ws

* ws
OliverEdy pushed a commit to OliverEdy/pycbc that referenced this pull request Apr 3, 2023
* hook up boundary types to dynesty

* nc

* ws

* ws
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants