Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid numpy 1.19 #3328

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Avoid numpy 1.19 #3328

merged 2 commits into from
Jun 22, 2020

Conversation

cdcapano
Copy link
Contributor

@cdcapano cdcapano commented Jun 22, 2020

No description provided.

@cdcapano cdcapano changed the title Test older numpy Test older numpy - ignore Jun 22, 2020
@ahnitz
Copy link
Member

ahnitz commented Jun 22, 2020

@cdcapano Pin it also in the setup.py and pyproject.toml and see

@cdcapano cdcapano changed the title Test older numpy - ignore Avoid numpy 1.19 Jun 22, 2020
@ahnitz
Copy link
Member

ahnitz commented Jun 22, 2020

@cdcapano Ok, this seems to pass now.

@ahnitz ahnitz merged commit 31102a2 into gwastro:master Jun 22, 2020
@cdcapano cdcapano deleted the check_numpy branch June 22, 2020 15:40
lenona pushed a commit to lenona/pycbc that referenced this pull request Sep 14, 2020
* try fixing numpy to 1.18.5 for py37

* add more numpy settings; make it <1.19 rather than pinning to 18.5
OliverEdy pushed a commit to OliverEdy/pycbc that referenced this pull request Apr 3, 2023
* try fixing numpy to 1.18.5 for py37

* add more numpy settings; make it <1.19 rather than pinning to 18.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants