Extend source classification to all kinds of GraceDB uploads #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An example of a trigger from SNR optimization can be seen in: https://gracedb-playground.ligo.org/events/T256619/view/ |
|
Thanks @veronica-villa, this looks great. Please see the comments I left and the code climate issues. |
titodalcanton
approved these changes
Feb 13, 2020
|
The Travis failure is unrelated to this, so merging. |
lenona
pushed a commit
to lenona/pycbc
that referenced
this pull request
Sep 14, 2020
…#3149) * Add source classification for the rest of GraceDB uploads * Add hdf5 to dict functions * Small corrections * Simplify save_hdf5_to_dict functions * Fixing codeclimate issues * Fixing codeclimate issues * Remove access to protected members
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
…#3149) * Add source classification for the rest of GraceDB uploads * Add hdf5 to dict functions * Small corrections * Simplify save_hdf5_to_dict functions * Fixing codeclimate issues * Fixing codeclimate issues * Remove access to protected members
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the source classification in PyCBC Live is only performed for triggers resulting from a two-detector coincidence. This PR extends it for the triggers resulting from the SNR maximization followup (
pycbc_optimize_snr) as well as single-detector triggers (check_singles()inpycbc_live).