Add calculation of source type probabilities to PyCBC Live #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example of an upload to gracedb-playground: https://gracedb-playground.ligo.org/events/T228684/view/ |
|
@veronica-villa feel free to click its "Resolve conversation" button when you think you have addressed one of my comments. |
veronica-villa
force-pushed
the
source_probabilities
branch
from
80585fc to
5e1ffee
Compare
veronica-villa
force-pushed
the
source_probabilities
branch
from
5e1ffee to
dad2999
Compare
added 2 commits
January 23, 2020 07:51
titodalcanton
changed the title
|
@veronica-villa I have a few remaining comments, once those are addressed I am happy with this. |
veronica-villa
commented
Jan 30, 2020
|
This is how it looks like in gracedb https://gracedb-playground.ligo.org/events/T250279/view/ |
titodalcanton
approved these changes
Feb 3, 2020
lenona
pushed a commit
to lenona/pycbc
that referenced
this pull request
Sep 14, 2020
) * Introduce source probability calculation * Mass gap probabilities improved * Change save function to add probs file * Change in z_delta and mchirp_delta * Add argument for mchirp_delta coefficient * Add mchirp bbh condition * Change save function * Add CBC probabilities to upload method * Small corrections to mchirp_area.py * Add logging messages * Fix small errors * Fix small syntax error * Fix codeclimate issues * Fix codeclimate issues * Fix codeclimate issues * Fix Travis issue * Changes in pie plot code * Remove unnecessary serialization to JSON file * Move distance and redshift estimations to mchirp_area module * Fix small errors * Fix codeclimate issue * Add color codes for the different CBC sources * Change option names and help strings * Assign colors to CBC sources and tag JSON file and plot as EM followup * Fix codeclimate issues * Change mc_area_args to be an attribute of LiveEventManager
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
) * Introduce source probability calculation * Mass gap probabilities improved * Change save function to add probs file * Change in z_delta and mchirp_delta * Add argument for mchirp_delta coefficient * Add mchirp bbh condition * Change save function * Add CBC probabilities to upload method * Small corrections to mchirp_area.py * Add logging messages * Fix small errors * Fix small syntax error * Fix codeclimate issues * Fix codeclimate issues * Fix codeclimate issues * Fix Travis issue * Changes in pie plot code * Remove unnecessary serialization to JSON file * Move distance and redshift estimations to mchirp_area module * Fix small errors * Fix codeclimate issue * Add color codes for the different CBC sources * Change option names and help strings * Assign colors to CBC sources and tag JSON file and plot as EM followup * Fix codeclimate issues * Change mc_area_args to be an attribute of LiveEventManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding code to calculate source probabilities from chirp mass and effective distance