Add mchirp_area codes #2951
Add mchirp_area codes #2951
Conversation
|
Can you try and fix the Travis issue by editing the docstring at the beginning of the file? |
|
@tdent Sorry I thought I had already done it. I think it is fixed now. |
|
Actually I think the codeclimate complaints about 'constant name not in upper case' are due to it thinking that the plotting codes which have .py file names are modules rather than scripts. If we want these to go away we would have to change the file names to not have .py at the end. However this is tricky or impossible to do that in the middle of a pull request via the web browser as far as I can see so we should possibly postpone that. |
There was a problem hiding this comment.
Other than the one equation spacing/formatting issue I comments on I think this is OK to commit as an initial step. Then we should change the script names to not end with .py and also start to split up the area calculation into separate pieces to make it shorter and more modular.
|
@tdent Equation spacing issue is now fixed, as well as the renaming of the scripts. |
|
@tdent Travis is failing due to the renaming of the scripts.. I don't know if it has a cache I can remove or something similar... |
|
What happens when you run the help command, i.e. pycbc_mchirp_plots --help ? |
|
See the second answer here : https://stackoverflow.com/questions/19425857/env-python-r-no-such-file-or-directory |
|
@tdent ok thanks, I will try to fix it! |
|
Ah, mass_area_plot now has a different Travis error : |
|
@tdent I think all Travis issues are fixed now! |
|
OK to merge, we will look at rebasing, splitting up functions etc. later. |
* Add mchirp_area codes * Update mchirp_plots.py * Update mass_area_plot.py * Update mchirp_plots.py * Update mass_area_plot.py * Update mchirp_area.py * Update mass_area_plot.py * Update mass_area_plot.py * Update mchirp_plots.py * Update mchirp_plots.py * Update mchirp_area.py * Update mass_area_plot.py * Update mass_area_plot.py * Update mass_area_plot.py * Update mass_area_plot.py * Update mchirp_area.py * Add docstring * Add docstrings and aliasing some modules * Solving codeclimate issues * Solving codeclimate issue * Rename mass_area_plot.py to mass_area_plot * Rename mass_area_plot to pycbc_mass_area_plot Also aliased some modules * Rename mchirp_plots.py as pycbc_mchirp_plots * Change equations spacing * Edit docstrings * Fixing Travis issues * Delete pycbc_mass_area_plot * Add pycbc_mass_area_plot * Change some imports * Delete pycbc_mchirp_plots * Add pycbc_mchirp_plots
* Add mchirp_area codes * Update mchirp_plots.py * Update mass_area_plot.py * Update mchirp_plots.py * Update mass_area_plot.py * Update mchirp_area.py * Update mass_area_plot.py * Update mass_area_plot.py * Update mchirp_plots.py * Update mchirp_plots.py * Update mchirp_area.py * Update mass_area_plot.py * Update mass_area_plot.py * Update mass_area_plot.py * Update mass_area_plot.py * Update mchirp_area.py * Add docstring * Add docstrings and aliasing some modules * Solving codeclimate issues * Solving codeclimate issue * Rename mass_area_plot.py to mass_area_plot * Rename mass_area_plot to pycbc_mass_area_plot Also aliased some modules * Rename mchirp_plots.py as pycbc_mchirp_plots * Change equations spacing * Edit docstrings * Fixing Travis issues * Delete pycbc_mass_area_plot * Add pycbc_mass_area_plot * Change some imports * Delete pycbc_mchirp_plots * Add pycbc_mchirp_plots
No description provided.