Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add in sigma variation into statistic #2850

Merged
merged 8 commits into from
Jul 23, 2019

Conversation

GarethCabournDavies
Copy link
Contributor

No description provided.

pycbc/events/stat.py Outdated Show resolved Hide resolved
pycbc/events/stat.py Outdated Show resolved Hide resolved
pycbc/events/stat.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tdent tdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks generally OK, only minor comments

pycbc/events/stat.py Show resolved Hide resolved
pycbc/events/stat.py Show resolved Hide resolved
@tdent tdent merged commit 639c3ea into gwastro:master Jul 23, 2019
@GarethCabournDavies GarethCabournDavies deleted the sigma_sensitivity branch November 20, 2019 10:39
lenona pushed a commit to lenona/pycbc that referenced this pull request Sep 14, 2020
* add in sigma variation into statistic

* better commenting/explanations. variables named as what they are. clarification of calculations by splitting

* leave ExpFitStatistic alone

* leave PhaseTDExpFitStatistic alone

* additional comments

* minor tweaks to comments
OliverEdy pushed a commit to OliverEdy/pycbc that referenced this pull request Apr 3, 2023
* add in sigma variation into statistic

* better commenting/explanations. variables named as what they are. clarification of calculations by splitting

* leave ExpFitStatistic alone

* leave PhaseTDExpFitStatistic alone

* additional comments

* minor tweaks to comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants