add median_sigma to fit_by_template and fit_over_multiparam #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prefer not to build statements that something is 'recent' into code that might stay around for years
tdent
approved these changes
Jul 18, 2019
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
…2843) * add median_sigma to fit_by_template and fit_over_multiparam * fix: accidentally hardcoded H1 * logging * couple of fixes to help/comments. prefer not to build statements that something is 'recent' into code that might stay around for years
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include median sigma value as an output to fit_by_template, and propagate through_fit_over_multiparam
This can then be used later in statistic calculation (for a later PR)