More Python 3 fixes for PyCBC Live #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spxiwh your comments are also appreciated (I know you diskile Python 3's strings ;) |
spxiwh
reviewed
Jun 25, 2019
spxiwh
reviewed
Jun 25, 2019
spxiwh
reviewed
Jun 25, 2019
|
I'm happy with the python3 - related changes. but I don't think I understand the wisdom code, so I'd like to wait for Alex to give final approval here. |
ahnitz
approved these changes
Jun 25, 2019
titodalcanton
changed the title
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
* Fix Py3 error with FFTW wisdom I/O * Fix int division on Py3 * Fix FFTW-related error with Py3 * Fix more int division issues with Py3 * Workaround for h5py not supporting Unicode arrays * Codeclimate and Ian's comments * Ian's comment * Codeclimate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a few more errors that happen when PyCBC Live runs under Python 3. With these changes, PyCBC Live successfully runs under Python 3 and produces HDF files as well as coinc LIGOLW files.
I have not yet done a careful checks of the correctness of the results and GraceDB uploads are not tested yet.
I am not sure about the h5py workaround I did for saving the approximant array. Comments/alternatives are welcome.