Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to limit which coincs to follow-up with multiifos #2572

Merged
merged 2 commits into from
Mar 14, 2019

Conversation

ahnitz
Copy link
Member

@ahnitz ahnitz commented Mar 13, 2019

No description provided.

@ahnitz
Copy link
Member Author

ahnitz commented Mar 13, 2019

This requires adding to the config file the following option.

--ifar-double-followup-threshold XXXX

Units in years like the standard ifar-upload-threshold option.
The option is required

@ahnitz
Copy link
Member Author

ahnitz commented Mar 13, 2019

@titodalcanton Ok, I think this works in my test in the sense that I see coincs above this threshold being output to xml files and below I see it in the hdf files with a 'NO_FOLLOWUP' key.

@tdent
Copy link
Contributor

tdent commented Mar 14, 2019

Does this need any further testing?

Copy link
Contributor

@titodalcanton titodalcanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason not to approve. The proof will be in the pudding.

@titodalcanton titodalcanton added this to the ER14 milestone Mar 14, 2019
@titodalcanton titodalcanton merged commit c038bc8 into gwastro:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants