Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyCBC Live test: generate PTA files and use a PTA-based ranking #3580

Closed
titodalcanton opened this issue Jan 11, 2021 · 3 comments · Fixed by #3596
Closed

PyCBC Live test: generate PTA files and use a PTA-based ranking #3580

titodalcanton opened this issue Jan 11, 2021 · 3 comments · Fixed by #3596
Labels
enhancement low latency

Comments

@titodalcanton
Copy link
Contributor

titodalcanton commented Jan 11, 2021 •
edited
Loading

The current example/test of PyCBC Live uses a simplistic --ranking-statistic quadsum which is not what was used in production during O3. Modify the example to create minimal PTA histogram files and use a ranking that includes the PTA term, such as phasetd.

Requires fixing #3584.
@ghost
Copy link

ghost commented Jan 15, 2021

@titodalcanton it's not totally clear from this description what the work required here is. Is 'implementing the required ranking' (as oppose to using it) part of this issue?

@titodalcanton
Copy link
Contributor Author

@dentt yeah, it was confusing. I opened a separate issue for the required ranking, and updated the above description.

@titodalcanton
Copy link
Contributor Author

It would make a lot of sense for a single PR to address both #3584 and #3580, by the way.

@titodalcanton titodalcanton mentioned this issue Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement low latency
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reimplement PhaseTDStatistic titodalcanton/pycbc
1 participant
@titodalcanton