Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept Uint8Array on dispatcher #1

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

kamecha
Copy link
Contributor

@kamecha kamecha commented Aug 18, 2024

It is useful when the other denops plugin which use Uint8Array use denops.dispatch("sixel_view", "img2sixel", file);.

For example...

const file: Uint8Array = await downloadFile(url);
const sixel = denops.dispatch("sixel_view", "img2sixel", file);
  // ↑ before this PR this line is Error (file is not String)

@gw31415
Copy link
Owner

gw31415 commented Aug 18, 2024

Nice PR! Thanks

@gw31415 gw31415 merged commit 243abf0 into gw31415:main Aug 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants