Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support self-signed certification #88

Closed
pyhedgehog opened this issue Dec 27, 2016 · 1 comment
Closed

Support self-signed certification #88

pyhedgehog opened this issue Dec 27, 2016 · 1 comment
Assignees
Milestone

Comments

@pyhedgehog
Copy link
Contributor

pyhedgehog commented Dec 27, 2016

PR #76 has a wrong implementation of requests.Session().verify value, which can be either boolean or reference to certificate to verify server against.

@guyzmo guyzmo added this to the milestone Dec 28, 2016
@guyzmo
Copy link
Owner

guyzmo commented Dec 28, 2016

I'm quite ok with PR #76 implementation (which made it to v1.8).

But I'd be happy to see it improved with the configuration accepting a file path to the certificate. If anybody needs it, I'm accepting a PR for that, otherwise I consider that rather low priority and I'll care about that at around v1.10 or after.

@guyzmo guyzmo added the backlog label Jan 22, 2017
guyzmo added a commit that referenced this issue Feb 2, 2017
- proxy support (using the gitconfig http configuration)
- custom certificate CA bundle setting
- support of scheme/port settings
- custom SSH URI setup
- and even a setting to define private repository upon creation

kudos to @pyhedgehog to force me into implementing that ☺

Fixes: #107
Fixes: #106
Fixes: #81
Fixes: #88
Signed-off-by: Guyzmo <guyzmo+github+pub@m0g.net>
guyzmo added a commit that referenced this issue Feb 2, 2017
- proxy support (using the gitconfig http configuration)
- custom certificate CA bundle setting
- support of scheme/port settings
- custom SSH URI setup
- and even a setting to define private repository upon creation

kudos to @pyhedgehog to force me into implementing that ☺

Fixes: #107
Fixes: #106
Fixes: #81
Fixes: #88
Signed-off-by: Guyzmo <guyzmo+github+pub@m0g.net>
@guyzmo guyzmo self-assigned this Feb 2, 2017
@guyzmo guyzmo added ready and removed in progress labels Feb 2, 2017
@guyzmo guyzmo closed this as completed in 3430cf0 Feb 2, 2017
@guyzmo guyzmo removed the ready label Feb 2, 2017
guyzmo added a commit that referenced this issue Feb 6, 2017
🚧 Features

* Gogs (fixes #18) (kudos @pyhedgehog)
* certificate pinning (fixes #88)
* non-standard http ports (fixes #81)
* possibility to use custom SSH address (fixes #107)
* .gitconfig in XDG home directory (fixes #95)
* .gitconfig's proxy definition support (fixes #105)
* automatically grab PR title/body from last commit (fixes #73)

🚒 Bugfixes

* refactoring of listings, improved list command (fixes #114)

💄 Cosmetics

* Switch to a git tag scheme for versioning (using setuptools-scm)
* Updated README with new informations
* Added @pyhedgehog to contributors
* Updated TODO list

Signed-off-by: Guyzmo <guyzmo+github+pub@m0g.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants