-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from Babel to Typescript. Fixes #801 #831
Conversation
Not sure why the Travis build is failing. Working okay locally for me. @mateusmarquezini - can you try pulling this branch and doing an |
@guyellis sure, I'm going to see what's happening with the build. |
@mateusmarquezini is it building and testing clean for you locally? I see this error on Travis but can't reproduce this locally. Can you see anything in the Travis file that would cause this? FAIL dist/test/learn/math/drill/finished.test.js
Finished
✕ should render when there is a single incorrect result (47ms)
✕ should render when there is a single correct result (17ms)
✕ should render when there is a mix of correct and incorrect results (12ms)
● Finished › should render when there is a single incorrect result |
@guyellis I can't reproduce it too. Locally everything works fine for me. I think this error should be something about CI config. I'll study that as soon as possible. |
@mateusmarquezini - I just locked all dependencies down to an exact version and fixed the merge conflict to see if that would change things... |
@guyellis I think the problem is related to jest settings in jest.config.js. I was following this thread yesterday jestjs/jest#7094 (comment) but it still not working. |
@mateusmarquezini - you were on the right path - awesome work! We just needed to relax the exclusion on that path. You solved it! |
@guyellis haha thanks! We solved it. Good work! |
No description provided.