Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolving file's relative parent path during optimization #57

Closed
jmonma opened this issue Mar 29, 2013 · 3 comments
Closed

resolving file's relative parent path during optimization #57

jmonma opened this issue Mar 29, 2013 · 3 comments

Comments

@jmonma
Copy link

jmonma commented Mar 29, 2013

I am able to build just fine when referencing css files that are children of the current directory (i.e. css!css/core). However, If I try to access a css folder that's a child of the parent directory it fails (i.e. css!../css/core).

My current setup:
/MyApp/css
/MyApp/css/core.css
/MyApp/js
/MyApp/js/example.js

When I try to build referencing a css file, it ends up resolving the url to the actual location of the plugin. So when I try to build referencing 'css!../css/core' from example.js, instead of resolving to /MyApp/css/core.css it resolves to /MyApp/js/lib/require/plugins/require-css/css/core.css and fails because that file does not exist.

Any thoughts on why this might be happening? I've tried it with my baseUrl at both /MyApp (css!css/core.css) and at /MyApp/js (css!../css/core.css) and both tried to resolve to the plugin folder instead of the actual file.

@guybedford
Copy link
Owner

I see what the problem is here, working on a fix and will report back soon.

guybedford added a commit that referenced this issue Mar 29, 2013
@guybedford
Copy link
Owner

I've included a fix in the master branch, let me know if this works for you.

@jmonma
Copy link
Author

jmonma commented Mar 29, 2013

This fixed the issue. Thanks for the rapid response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants