Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update routes api with headscale #83

Closed
wants to merge 1 commit into from
Closed

update routes api with headscale #83

wants to merge 1 commit into from

Conversation

yangboyd
Copy link

Headscale updated protos with new routes API
juanfont/headscale@1b557ac

@yangboyd yangboyd mentioned this pull request Dec 14, 2022
Closed
routerino
routerino reviewed Dec 16, 2022
View reviewed changes
Copy link
Contributor

@routerino routerino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look through, from my understanding this will only work with headscale 18+, correct? In which case this can be committed but can't be released until 18 leaves beta.

@routerino
Copy link
Contributor

routerino commented Dec 23, 2022 •
edited
Loading

Hi @yangboyd, I've written a new pull request #85 that allows both legacy and normal APIs to interact without conflict. I'll credit you for the initial work though.

@routerino routerino closed this Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@routerino routerino routerino left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yangboyd @routerino